Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validation: add check for backgroundColor != textColor #203

Merged
merged 2 commits into from
Jun 21, 2024
Merged

validation: add check for backgroundColor != textColor #203

merged 2 commits into from
Jun 21, 2024

Conversation

jheubuch
Copy link
Collaborator

As described in #200 (comment)

jheubuch
jheubuch commented Jun 21, 2024
View reviewed changes
Copy link
Collaborator Author

@jheubuch jheubuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooof I can't approve even tho it's not my code. 🙃

@jheubuch jheubuch requested a review from marhei June 21, 2024 20:30
@marhei marhei merged commit b2a205d into main Jun 21, 2024
4 checks passed
@marhei marhei deleted the add-validation branch June 21, 2024 20:33
@jheubuch
Copy link
Collaborator Author

That was fast. Thank you <3

@marhei
Copy link
Contributor

marhei commented Jun 22, 2024

Review à grande vitesse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marhei marhei marhei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jheubuch @marhei @jeyemwey